fbt/sbase
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check explicit length in od(1)

Browse Source 
If you pass an empty string, the null-char will always match
with strchr()!
This commit is contained in:
FRIGN 2015-09-29 23:14:59 +02:00 committed by sin
parent d49bce7fc8
commit 0d6d1dc02f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
od.c
View File

@ -108,13 +108,13 @@ main(int argc, char *argv[])
ARGBEGIN { ARGBEGIN {
case 'A': case 'A':
s = EARGF(usage()); s = EARGF(usage());
if (strlen(s) > 1 || !strchr("doxn", s[0])) if (strlen(s) != 1 || !strchr("doxn", s[0]))
usage(); usage();
radix = s[0]; radix = s[0];
break; break;
case 't': case 't':
s = EARGF(usage()); s = EARGF(usage());
if (strlen(s) > 1 || !strchr("acdoux", s[0])) if (strlen(s) != 1 || !strchr("acdoux", s[0]))
usage(); usage();
type = s[0]; type = s[0];
break; break;