fbt/sbase
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Convert chown() failure to a warning in tar(1)

Browse Source 
This particular change does not have any immediate shortcomings.
We still print a warning to alert the user.

Exiting on a chown() failure caused problems when untarring
inside a restricted user namespace on Linux where the uid/gid
mappings were limited.
This commit is contained in:
sin 2015-04-21 09:15:13 +01:00
parent ce145a39a7
commit 542f645bc2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tar.c
View File

@ -242,7 +242,7 @@ unarchive(char *fname, ssize_t l, char b[BLKSIZ])
if ((gid = strtol(h->gid, &p, 8)) < 0 || *p != '\0') if ((gid = strtol(h->gid, &p, 8)) < 0 || *p != '\0')
eprintf("strtol %s: invalid number\n", h->gid); eprintf("strtol %s: invalid number\n", h->gid);
if (!getuid() && chown(fname, uid, gid)) if (!getuid() && chown(fname, uid, gid))
eprintf("chown %s:", fname); weprintf("chown %s:", fname);
for (; l > 0; l -= BLKSIZ) { for (; l > 0; l -= BLKSIZ) {
if (fread(b, BLKSIZ, 1, tarfile) != 1) if (fread(b, BLKSIZ, 1, tarfile) != 1)