Don't return but _exit after failed exec*() and fork()
Quoting POSIX[0]: "Care should be taken, also, to call _exit() rather than exit() if exec cannot be used, since exit() flushes and closes standard I/O channels, thereby damaging the parent process' standard I/O data structures. (Even with fork(), it is wrong to call exit(), since buffered data would then be flushed twice.)" [0]: http://pubs.opengroup.org/onlinepubs/009695399/functions/vfork.html
This commit is contained in:
		
							
								
								
									
										5
									
								
								time.c
									
									
									
									
									
								
							
							
						
						
									
										5
									
								
								time.c
									
									
									
									
									
								
							@@ -41,11 +41,12 @@ main(int argc, char *argv[])
 | 
			
		||||
 | 
			
		||||
	switch ((pid = fork())) {
 | 
			
		||||
	case -1:
 | 
			
		||||
		eprintf("fork:");
 | 
			
		||||
		weprintf("fork:");
 | 
			
		||||
		_exit(1);
 | 
			
		||||
	case 0:
 | 
			
		||||
		execvp(argv[0], argv);
 | 
			
		||||
		savederrno = errno;
 | 
			
		||||
		weprintf("exec %s:", argv[0]);
 | 
			
		||||
		weprintf("execvp %s:", argv[0]);
 | 
			
		||||
		_exit(126 + (savederrno == ENOENT));
 | 
			
		||||
	default:
 | 
			
		||||
		break;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user