fbt/sbase
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Tweak NULL-pointer checks

Browse Source 
Use !p and p when comparing pointers as opposed to explicit
checks against NULL.  This is generally easier to read.
This commit is contained in:
FRIGN
2014-11-13 22:16:29 +01:00
committed by sin
parent ec8246bbc6
commit 7fc5856e64
8 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sort.c
View File

@@ -238,12 +238,12 @@ skipblank(char *s)
static char *
nextcol(char *s)
{
if (fieldsep == NULL) {
if (!fieldsep) {
s = skipblank(s);
while(*s && !isblank(*s))
s++;
} else {
if (strchr(s, *fieldsep) == NULL)
if (!strchr(s, *fieldsep))
s = strchr(s, '\0');
else
s = strchr(s, *fieldsep) + 1;
@@ -274,11 +274,11 @@ columns(char *line, const struct keydef *kd)
else
end = nextcol(end);
} else {
if ((end = strchr(line, '\n')) == NULL)
if (!(end = strchr(line, '\n')))
end = strchr(line, '\0');
}
if ((res = strndup(start, end - start)) == NULL)
if (!(res = strndup(start, end - start)))
enprintf(2, "strndup:");
return res;
}