fbt/sbase
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify expression in makeline()

Browse Source 
This expression was wrong, but it was causing a false positive
in some compilers that couldn't see that error() cannot return.
The actual problem of the line is that it was too complex and it is better
to split it in simplex expressions.
This commit is contained in:
Roberto E. Vargas Caballero 2018-03-06 14:38:23 +01:00 committed by sin
parent 18f6c5e014
commit f45156d5b4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ed.c
View File

@ -192,8 +192,10 @@ makeline(char *s, int *off)
char c, *begin = s; char c, *begin = s;
if (lastidx >= idxsize) { if (lastidx >= idxsize) {
if (idxsize > SIZE_MAX - NUMLINES || lp = NULL;
!(lp = realloc(zero, (idxsize + NUMLINES) * sizeof(*lp)))) if (idxsize <= SIZE_MAX - NUMLINES)
lp = realloc(zero, (idxsize + NUMLINES) * sizeof(*lp));
if (!lp)
error("out of memory"); error("out of memory");
idxsize += NUMLINES; idxsize += NUMLINES;
zero = lp; zero = lp;