3111908b03
Okay, why yet another recurse()-refactor? The last one added the recursor-struct, which simplified things on the user-end, but there was still one thing that bugged me a lot: Previously, all fn()'s were forced to (l)stat the paths themselves. This does not work well when you try to keep up with H-, L- and P- flags at the same time, as each utility-function would have to set the right function-pointer for (l)stat every single time. This is not desirable. Furthermore, recurse should be easy to use and not involve trouble finding the right (l)stat-function to do it right. So, what we needed was a stat-argument for each fn(), so it is directly accessible. This was impossible to do though when the fn()'s are still directly called by the programs to "start" the recurse. Thus, the fundamental change is to make recurse() the function to go, while designing the fn()'s in a way they can "live" with st being NULL (we don't want a null-pointer-deref). What you can see in this commit is the result of this work. Why all this trouble instead of using nftw? The special thing about recurse() is that you tell the function when to recurse() in your fn(). You don't need special flags to tell nftw() to skip the subtree, just to give an example. The only single downside to this is that now, you are not allowed to unconditionally call recurse() from your fn(). It has to be a directory. However, that is a cost I think is easily weighed up by the advantages. Another thing is the history: I added a procedure at the end of the outmost recurse to free the history. This way we don't leak memory. A simple optimization on the side: - if (h->dev == st.st_dev && h->ino == st.st_ino) + if (h->ino == st.st_ino && h->dev == st.st_dev) First compare the likely difference in inode-numbers instead of checking the unlikely condition that the device-numbers are different.
41 lines
826 B
C
41 lines
826 B
C
/* See LICENSE file for copyright and license details. */
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
struct history {
|
|
struct history *prev;
|
|
dev_t dev;
|
|
ino_t ino;
|
|
};
|
|
|
|
struct recursor {
|
|
void (*fn)(const char *, struct stat *st, void *, struct recursor *);
|
|
struct history *hist;
|
|
int depth;
|
|
int follow;
|
|
int flags;
|
|
};
|
|
|
|
enum {
|
|
SAMEDEV = 1 << 0,
|
|
};
|
|
|
|
extern int cp_aflag;
|
|
extern int cp_fflag;
|
|
extern int cp_pflag;
|
|
extern int cp_rflag;
|
|
extern int cp_vflag;
|
|
extern int cp_HLPflag;
|
|
extern int cp_status;
|
|
|
|
extern int rm_fflag;
|
|
extern int rm_rflag;
|
|
extern int rm_status;
|
|
|
|
extern int recurse_status;
|
|
|
|
void recurse(const char *, void *, struct recursor *);
|
|
|
|
int cp(const char *, const char *, int);
|
|
void rm(const char *, struct stat *st, void *, struct recursor *);
|