01de5df8e6
While auditing du(1) I realized that there's no way the over 100 lines of procedures in du() would pass the audit. Instead, I decided to rewrite this section using recurse() from libutil. However, the issue was that you'd need some kind of payload to count the number of bytes in the subdirectories and use them in the higher hierarchies. The solution is to add a "void *data" data pointer to each recurse- function-prototype, which we might also be able to use in other recurse-applications. recurse() itself had to be augmented with a recurse_samedev-flag, which basically prevents recurse from leaving the current device. Now, let's take a closer look at the audit: 1) Removing the now unnecessary util-functions push, pop, xrealpath, rename print() to printpath(), localize some global variables. 2) Only pass the block count to nblks instead of the entire stat- pointer. 3) Fix estrtonum to use the minimum of LLONG_MAX and SIZE_MAX. 4) Use idiomatic argv+argc-loop 5) Report proper exit-status.
61 lines
961 B
C
61 lines
961 B
C
/* See LICENSE file for copyright and license details. */
|
|
#include <sys/stat.h>
|
|
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
|
|
#include "fs.h"
|
|
#include "util.h"
|
|
|
|
static int mv_status = 0;
|
|
|
|
static int
|
|
mv(const char *s1, const char *s2, int depth)
|
|
{
|
|
if (!rename(s1, s2))
|
|
return (mv_status = 0);
|
|
if (errno == EXDEV) {
|
|
cp_aflag = cp_rflag = cp_pflag = 1;
|
|
cp_HLPflag = 'P';
|
|
rm_rflag = 1;
|
|
cp(s1, s2, depth);
|
|
rm(s1, 0, NULL);
|
|
return (mv_status = cp_status || rm_status);
|
|
}
|
|
mv_status = 1;
|
|
|
|
return -1;
|
|
}
|
|
|
|
static void
|
|
usage(void)
|
|
{
|
|
eprintf("usage: %s [-f] source ... dest\n", argv0);
|
|
}
|
|
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
struct stat st;
|
|
|
|
ARGBEGIN {
|
|
case 'f':
|
|
break;
|
|
default:
|
|
usage();
|
|
} ARGEND;
|
|
|
|
if (argc < 2)
|
|
usage();
|
|
|
|
if (argc > 2) {
|
|
if (stat(argv[argc - 1], &st) < 0)
|
|
eprintf("stat %s:", argv[argc - 1]);
|
|
if (!S_ISDIR(st.st_mode))
|
|
eprintf("%s: not a directory\n", argv[argc - 1]);
|
|
}
|
|
enmasse(argc, argv, mv);
|
|
|
|
return mv_status;
|
|
}
|