Fix: ufw does nothing without a positional argument even if it's not required

Signed-off-by: fbt <fbt@fleshless.org>

README.md

@@ -13,38 +13,13 @@ Scripts
 ufw
 ---
 
-ufw is the main one, it uploads shit.
+ufw can upload files to 8fw.me, shorten urls and show you your ip.  
+Call ufw -h for help.
 
-
-	Usage: ufw [-RsF] [-D num] [file/url]"
-	    Flags:
-	        -R                   # Remove the file after uploading.
-	        -s                   # Make a screenshot and upload it instead of a file.
-	        -F                   # Make a fullscreen shot instead of prompting for a window/area. Implies -s.
-	        -d                   # Supply a dexcription.
-	        -D <num>             # Delay the shot by <num> seconds.
-	        -p                   # Make the file public.
-	        -u                   # Generate a shortlink from URL.
-	        -m                   # Maximum filesize (takes K, M and G suffixes).
-	        -a                   # Add the file to an album.
-	        -A                   # API response format.
-	
-	    Config options (~/.config/ufw):
-	        secret               # Your personal token. Get it at https://zfh.so/settings_form
-	        cfg_screenshot_ext   # Screenshot file type, used by scrot.
-	        cfg_max_filesize     # Maximum filesize in megabytes.
-	        # Others are self-explanatory:
-	        cfg_url_regex
-	        cfg_tmp_dir
-	        cfg_service_url
+Dependencies: curl, jshon
 
 ufwd
 ----
 
 ufwd periodically checks a directory of your choosing (defaults to $XDG_RUNTIME DIR/ufwd) and invokes ufw to upload the files and remove them.  
-
-	Usage: ufwd [-hn] [-d workdir] -D [check delay] -- [ufw flags]
-	   -h            # Show this message.
-	   -n            # Enable notifications with notify-send. Must be installed.
-	   -d [path]     # Set the dir that is to be watched.
-	   -D [sec]      # Set the check interval.
+Call ufwd -h for help.

ufw

@@ -15,8 +15,13 @@ is_url() {
 	[[ "$1" =~ $cfg_url_regex ]]
 }
 
-msg() { printf '%s\n' "[ufw] $1"; }
-err() { msg "(error) $1" >&2; }
+msg() {
+	if ! (( flag_quiet )); then
+		printf '%s\n' "$1"
+	fi
+}
+
+err() { printf '(error) %s\n' "$*" >&2;  }
 
 usage() {
 	_cat <<- EOF
@@ -28,17 +33,17 @@ usage() {
 		        -d|--description              # Supply a description.
 		        -D|--screenshot-delay <num>   # Delay the shot by <num> seconds.
 		        -p|--public                   # Make the file public.
-		        -u|--short                    # Generate a shortlink from URL.
-		        -m|--max-filesize             # Maximum filesize (takes K, M and G suffixes).
+		        -u|--shorten <URL>            # Generate a shortlink from URL.
+		        -S|--short-url                # Get a shortlink when uploading a file.
+		        -P|--page-url                 # Get a link to the file page instead of a direct one.
+		        -m|--max-filesize <num>[suf]  # Maximum filesize (takes K, M and G suffixes).
 		        -a|--album-id                 # Add the file to an album.
-		        -A|--album-name               # Add the file to an album by name. The album will be crated, if necessary.
-		        -M|--api-format               # API response format.
+		        -A|--album-name               # Add the file to an album by name. The album will be created, if necessary.
 		
 		    Config options (~/.config/ufw):
 		        secret               # Your personal token. Get it at https://zfh.so/settings_form
-		        cfg_screenshot_ext   # Screenshot file type, used by scrot.
+		        cfg_screenshot_ext   # Screenshot file type, used by maim.
 		        cfg_max_filesize     # Maximum filesize (takes K, M and G suffixes).
-		        cfg_api_format       # Set the api response format. Supports json or plain (default).
 		        # Others are self-explanatory:
 		        cfg_url_regex
 		        cfg_tmp_dir
@@ -47,12 +52,6 @@ usage() {
 	EOF
 }
 
-ensure_env() {
-	for i in "$cfg_tmp_dir"; do
-		[[ -d "$i" ]] || { mkdir -p "$i"; }
-	done
-}
-
 get_file_hash() {
 	read file_hash _ < <( sha1sum "$1" )
 }
@@ -73,8 +72,26 @@ get_max_filesize() {
 	fi
 }
 
+get_album_id() {
+	declare api_response api_status api_status_message
+
+	api_response=$( curl -fsL "$cfg_service_url/$cfg_api_path/album?a=new&name=$1&format=json&secret=$secret" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		album_id=$( jshon -e data -e album -e id -u <<< "$api_response" )
+		misc_curl_args+=( -F album_id="$album_id" )
+	else
+		printf 'Error [album]: %s %s\n' "$api_status" "$api_status_message"
+		return 1
+	fi
+}
+
 upload() {
-	if (( flag_scrot )); then
+	declare api_response api_status api_status_message
+
+	if (( flag_scn )); then
 		flag_rm=1
 		file=$(take_screenshot) || { return 1; }
 	else
@@ -115,58 +132,83 @@ upload() {
 	get_file_hash "$file"
 
 	if [[ "$album_name" ]]; then
-		if album_id=$( curl -fsL "$cfg_service_url/$cfg_api_path/album?a=new&name=$album_name&format=plain&secret=$secret" ); then
-			misc_curl_args+=( -F album_id="$album_id" )
-		else
-			return 1
-		fi
+		get_album_id "$album_name"
 	fi
 
-	curl -sL \
+	api_response=$( curl -sL \
 		-F file="@$file" \
-		-F api_format="$cfg_api_format" \
+		-F api_format='json' \
 		-F flag_private="$flag_private" \
-		-F short="$flag_shortlink" \
 		-F secret="$secret" \
 		-F submit="" \
 		"${misc_curl_args[@]}" \
 		-A 'zerofiles.org upload script' \
-		"$cfg_service_url/$cfg_api_path/upload"
+		"$cfg_service_url/$cfg_api_path/upload" )
 
-	if (( $? )); then
-		err 'Something has gone wrong with the upload.'
-		return 7
+	if (( flag_shortlink )); then
+		if (( flag_directlink )); then
+			file_url_request='short_url_direct'
 		else
+			file_url_request='short_url'
+		fi
+	else
+		if (( flag_directlink )); then
+			file_url_request='direct_url'
+		else
+			file_url_request='page_url'
+		fi
+	fi
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		file_link=$( jshon -e data -e file -e "$file_url_request" -u <<< "$api_response" )
+
+		printf '%s\n' "$file_link"
+
 		if (( flag_rm )); then
 			msg "Removing file: $file"
 			rm "$file"
 		fi
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+		return 1
 	fi
 }
 
 get_shortlink() {
-	declare url=$1
+	declare url=$1 api_response api_status api_status_message
 
-	if ! curl -fsL "$cfg_service_url/api?mode=url_add&url=${url}&raw=1"; then
-		err 'Something went wrong!'
+	api_response=$( curl -sL "$cfg_service_url/$cfg_api_path/url?a=add&url=${url}&format=json&secret=$secret" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		read -r short_url real_url < <(
+			jshon -e data -e URL -e shorturl -u <<< "$api_response"
+		)
+
+		printf '%s\n' "$short_url"
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
 	fi
 }
 
 take_screenshot() {
 	declare tmp_file
 
-	[[ "$scrot_exec" ]] || { scrot_exec=$(type -P scrot); }
-	[[ "$scrot_exec" ]] || {
-		err "Please install scrot to use this function"
+	[[ "$scn_exec" ]] || { scn_exec=$(type -P maim); }
+	[[ "$scn_exec" ]] || {
+		err "Please install maim to use this function"
 		return 1
 	}
 
-	(( "$flag_scrot_fullscreen" )) || { scrot_args+=( '-s' ); }
-	[[ "$cfg_scrot_delay" ]] && { scrot_args+=( "-d $cfg_scrot_delay" ); }
+	(( "$flag_scn_fullscreen" )) || { scn_args+=( '-s' ); }
+	[[ "$cfg_scn_delay" ]] && { scn_args+=( "-d $cfg_scn_delay" ); }
 
 	tmp_file="$(_mktemp "${cfg_tmp_dir}" ".${cfg_screenshot_ext}")"
 
-	scrot "${scrot_args[@]}" "$tmp_file" || {
+	maim "${scn_args[@]}" "$tmp_file" || {
 		err "Failed to take a screenshot."
 		return 1
 	}
@@ -174,6 +216,16 @@ take_screenshot() {
 	printf '%s\n' "$tmp_file"
 }
 
+get_api_status() {
+	read -d '' -r api_status api_status_message < <(
+		jshon -e status -e code -u -p -e message -u
+	)
+
+	if ! (( api_status == 200 )); then
+		return 1
+	fi
+}
+
 _mktemp() {
 	declare tmp_file_name tmp_file_name_extra="$2" tmp_dir="$1" 
 
@@ -190,10 +242,29 @@ _mktemp() {
 }
 
 get_my_ip() {
-	my_ip=$( curl -fsL https://zfh.so/ip )
+	declare api_response api_status api_status_message my_ip
 
-	if ! (( $? )); then
-		printf '%s\n' $my_ip
+	api_response=$( curl -sl "$cfg_service_url/$cfg_api_path/ip?format=json" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		my_ip=$( jshon -e data -e ip -u <<< "$api_response" )
+		printf '%s\n' "$my_ip"
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+	fi
+}
+
+login() {
+	declare api_response
+
+	api_response=$( curl -sl "$cfg_service_url/$cfg_api_path/get_login_token?login=$login&format=json" )
+
+	if get_api_status <<< "$api_response"; then
+		printf 'Check your email.\n'
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
 	fi
 }
 
@@ -233,7 +304,7 @@ set_argv() {
 }
 
 main() {
-	declare args file target flag_private flag_rm flag_scrot flag_scrot_fullscreen cfg_scrot_delay
+	declare args file target flag_private flag_rm flag_scn flag_scn_fullscreen cfg_scn_delay
 	declare flag_shortlink=0
 
 	# Defaults for XDG
@@ -250,9 +321,11 @@ main() {
 	cfg_service_url='https://8fw.me'
 	cfg_screenshot_ext='png'
 	cfg_max_filesize='200M'
-	cfg_api_format='plain'
 	cfg_api_path='/api/2'
 
+	flag_shortlink=0
+	flag_directlink=1
+
 	if [[ -f "$HOME/.suprc" ]]; then
 		printf 'Found legacy configfile, moving...\n' >&2
 		mv "$HOME/.suprc" "$XDG_CONFIG_DIR/ufw"
@@ -267,52 +340,72 @@ main() {
 
 	while [[ "$1" ]]; do
 		case "$1" in
-			-p|--public) flag_private='false';;
-			-R|--remove-file) flag_rm='1';;
-			
-			-s|--screenshot) flag_scrot='1';;
-			-D|--screenshot-delay) cfg_scrot_delay="$2"; shift;;
-			-F|--fullscreen)
-				flag_scrot='1'
-				flag_scrot_fullscreen='1'
-			;;
-
+			-h|--help|--usage) usage; return;;
+			-D|--screenshot-delay) cfg_scn_delay="$2"; shift;;
 			-m|--max-filesize) cfg_max_filesize=$2; shift;;
-
-			-M|--api-format) cfg_api_format=$2; shift;;
+			-A|--album-name) album_name=$2; shift;;
 
 			-i|--my-ip) action='getmyip';;
+			-u|--shorten) action='url';;
 
-			-S|--short) flag_shortlink='1';;
-			-u|--url) action='url';;
+			-p|--public) flag_private='false';;
+			-R|--remove-file) flag_rm='1';;
+			-s|--screenshot) flag_scn='1';;
+			-S|--short-url) flag_shortlink=1;;
+			-P|--page-url) flag_directlink=0;;
+			-q|--quiet) flag_quiet=1;;
+
+			-F|--fullscreen)
+				flag_scn='1'
+				flag_scn_fullscreen='1'
+			;;
 
 			-a|--album-id)
 				misc_curl_args+=( -F "album_id=$2" )
 				shift
 			;;
 
-			-A|--album-name) album_name=$2; shift;;
-
 			-d|--description)
 				misc_curl_args+=( -F "description=$2" )
 				shift
 			;;
 
-			-h|--help|--usage) usage; return;;
-
 			--) shift; break;;
 
+			-*)
+				err "Unknown flag: $1"
+				usage
+				return 1
+			;;
+
 			*) break;;
 		esac
 		shift
 	done
 
-	ensure_env
+	for i in "$cfg_tmp_dir"; do
+		[[ -d "$i" ]] || { mkdir -p "$i"; }
+	done
 
 	case "${action:-upload}" in
-		upload) upload "$1";;
-		url) get_shortlink "$1";;
+		upload)
+			if (( $# )); then
+				for t in "$@"; do
+					upload "$t"
+				done
+			else
+				upload
+			fi
+		;;
+
+		url)
+			for t in "$@"; do
+				get_shortlink "$1"
+			done
+		;;
+
 		getmyip) get_my_ip;;
+		login) login;;
 	esac
 }
 

ufwd

@@ -6,10 +6,6 @@ if ! [[ "$XDG_RUNTIME_DIR" ]]; then
 	XDG_RUNTIME_DIR="/run/user/$UID"
 fi
 
-# Defaults
-cfg_workdir="$XDG_RUNTIME_DIR/ufwd"
-cfg_scan_delay='30'
-
 msg() { printf '%s\n' "$*"; }
 err() { echo "$*" >&2; }
 
@@ -18,51 +14,12 @@ usage() {
 	printf '   -h            # Show this message.\n'
 	printf '   -n            # Enable notifications with notify-send. Must be installed.\n'
 	printf '   -d [path]     # Set the dir that is to be watched.\n'
-	printf '   -D [sec]      # Set the check interval.\n'
 }
 
-main() {
-	while (( $# )); do
-		case "$1" in
-			(--help|-h) usage; return 0;;
+upload() {
+	declare file=$1; shift
 
-			(--workdir|-d) cfg_workdir="$2"; shift;;
-			(--scan-delay|-D) cfg_scan_delay="$2"; shift;;
-
-			(--notify|-n) flag_enable_notifications=1;;
-
-			(--) shift; break;;
-			(-*)
-				err "Unknown key: $1"
-				usage
-				return 1
-			;;
-
-			(*) break;;
-		esac
-		shift
-	done
-
-	if (( flag_enable_notifications )); then
-		if type -P notify-send &>/dev/null; then
-			msg "Found notify-send."
-		else
-			err "notify-send not found in PATH, disabling notifications."
-			flag_enable_notifications=0
-		fi
-	fi
-
-	mkdir -p "$cfg_workdir" || {
-		return 1
-	}
-
-	cd "$cfg_workdir" || {
-		return 1
-	}
-
-	while sleep "$cfg_scan_delay"; do
-		for i in *; do
-			upload_output=$( ufw "$@" -R "$i" )
+	upload_output=$( ufw -R "$@" "$file" )
 	upload_return=$?
 
 	if (( flag_enable_notifications )); then
@@ -73,9 +30,51 @@ main() {
 		fi
 	fi
 
+	if (( flag_enable_clipboard )); then
+		read -r fl <<< "$upload_output"
+		xclip <<< "$fl"
+	fi
+
 	printf '%s\n' "$upload_output"
+}
+
+main() {
+	while (( $# )); do
+		case "$1" in
+			(--help|-h) usage; return 0;;
+			(--notify|-n) flag_enable_notifications=1;;
+			(--clipboard|-c) flag_enable_clipboard=1;;
+
+			(--workdir|-d) cfg_workdir+=( "$2" ); shift;;
+
+			(--) shift; break;;
+			(-*) err "Unknown key: $1"; usage; return 1;;
+			(*) break;;
+		esac
+		shift
 	done
+
+	[[ $cfg_workdir ]] || cfg_workdir="$XDG_RUNTIME_DIR/ufwd"
+
+	if (( flag_enable_notifications )); then
+		if type -P notify-send &>/dev/null; then
+			msg "Found notify-send."
+		else
+			err "notify-send not found in PATH, disabling notifications."
+			flag_enable_notifications=0
+		fi
+	fi
+
+	for p in "${cfg_workdir[@]}"; do
+		[[ -d "$p" ]] || return 1
 	done
+
+	printf 'Working in:\n'
+	printf ' - %s\n' "${cfg_workdir[@]}"
+
+	while read -r d e f; do
+		upload "$d$f" "$@" &
+	done < <( inotifywait -m -e close_write "${cfg_workdir[@]}" )
 }
 
 main "$@"