Fix: ufw does nothing without a positional argument even if it's not required

Signed-off-by: fbt <fbt@fleshless.org>

README.md

@@ -1,23 +1,25 @@
-LICENSE
-=======
-All scripts here are released uder the ISC permissive free software license (http://en.wikipedia.org/wiki/ISC_license).
-It basically says that you can do whatever you like with the code as long as you credit the author and provide the license with it.
-Also see LICENSE in the repo.
+ufw-tools
+=========
+
+ufw-tools are two simple-ish scripts for uploading files to 8fw.me.
 
 Support
 =======
 I do not promise any support for any of the provided scripts. That said, I'll do what I can for you if I'm not too busy and/or drunk.
 
-General information
-===================
-The paths are all configurable of course.
-The help information that the scripts give is dynamic and is provided here only for reference.
-
 Scripts
 =======
 
-sup
+ufw
 ---
-A very simple tool to upload files to the zfh.so file hosting
 
-	Usage: sup [-RsF] [-D num] [file/url]
+ufw can upload files to 8fw.me, shorten urls and show you your ip.  
+Call ufw -h for help.
+
+Dependencies: curl, jshon
+
+ufwd
+----
+
+ufwd periodically checks a directory of your choosing (defaults to $XDG_RUNTIME DIR/ufwd) and invokes ufw to upload the files and remove them.  
+Call ufwd -h for help.

sup

@@ -1,179 +0,0 @@
-#!/usr/bin/env bash
-# Copyright (c) 2012 fbt <fbt@fleshless.org>
-#
-# About:
-# A simple upload script for ZFH (http://zerofiles.org)
-
-_self="${0##*/}"
-
-cfg_url_regex='^[A-Za-z]([A-Za-z0-9+.-]+)?://.+'
-cfg_tmp_dir="/tmp/$USER/sup"; TEMPDIR="$cfg_tmp_dir"
-cfg_script_url='https://zfh.so/upload'
-cfg_screenshot_ext='png'
-
-[[ -f $HOME/.suprc ]] && { source "$HOME/.suprc"; }
-
-sup.msg() { printf '%s\n' "[sup] $1"; }
-sup.err() { sup.msg "(error) $1" >&2; }
-
-sup.usage() {
-	printf '%s\n' "Usage: ${_self} [-RsF] [-D num] [file/url]"
-}
-
-sup.env() {
-	for i in "$cfg_tmp_dir"; do
-		[[ -d "$i" ]] || { mkdir -p "$i"; }
-	done
-}
-
-sup.upload() {
-	curl -F file="@$file" \
-		-F upload_mode='api' \
-		-F flag_private="$flag_private" \
-		-F secret="$secret" \
-		-F submit="" \
-		"$cfg_script_url" -sL -A 'zerofiles.org upload script' || { return 1; }
-
-	(( "$flag_rm" )) && { rm "$file"; }
-
-	return 0
-}
-
-sup.mktemp() {
-	>"$1" || {
-		sup.err "Cannot create $1!"
-		return 1
-	}
-
-	printf '%s\n' "$1"
-}
-
-sup.scrot() {
-	declare tmp_file
-
-	[[ "$scrot_exec" ]] || { scrot_exec=$(type -P scrot); }
-	[[ "$scrot_exec" ]] || {
-		sup.err "Please install scrot to use this function"
-		return 1
-	}
-
-	(( "$flag_scrot_fullscreen" )) || { scrot_args+=( '-s' ); }
-	[[ "$cfg_scrot_delay" ]] && { scrot_args+=( "-d $cfg_scrot_delay" ); }
-
-	tmp_file="$(sup.mktemp "${cfg_tmp_dir}" ".${cfg_screenshot_ext}")"
-
-	scrot "${scrot_args[@]}" "$tmp_file" || {
-		sup.err "Failed to take a screenshot."
-		return 1
-	}
-
-	printf '%s\n' "$tmp_file"
-}
-
-sup.if_url() { printf '%s\n' "$1" | grep -oE "$cfg_url_regex" &>/dev/null; }
-
-sup.mktemp() {
-	declare tmp_file_name tmp_file_name_extra="$2" tmp_dir="$1" 
-
-	[[ -d "$tmp_dir" ]] || {
-		sup.err "${tmp_dir} does not exist or is not a directory."
-		return 1
-	}
-
-	until [[ ! -e "${tmp_dir}/${tmp_file_name}" ]]; do
-		tmp_file_name="${RANDOM}${RANDOM}${tmp_file_name_extra}"
-	done
-
-	printf '%s\n' "${tmp_dir}/${tmp_file_name}"
-}
-
-sup.set_argv() {
-	declare arg opt c
-	declare -g argv
-
-	while (( $# )); do
-		unset -v arg opt c
-
-		case "$1" in
-			(--) argv+=( "$1" ); break;;
-
-			(--*)
-				IFS='=' read arg opt <<< "$1"
-				argv+=( "$arg" )
-
-				[[ "$opt" ]] && {
-					argv+=( "$opt" )
-				}
-			;;
-
-			(-*)
-				while read -n1 c
-				do
-					case "$c" in
-						-|'') :;;
-						*) argv+=( "-$c" );;
-					esac
-				done <<< "$1"
-			;;
-
-			(*) argv+=( "$1" );;
-		esac
-		shift
-	done
-}
-
-main() {
-	declare args file target flag_private flag_rm flag_scrot flag_scrot_fullscreen cfg_scrot_delay
-
-	while [[ "$1" ]]; do
-		case "$1" in
-			-p|--private) flag_private='true';;
-			-R|--remove-file) flag_rm='1';;
-			
-			-s|--screenshot) flag_scrot='1';;
-			-F|--fullscreen) flag_scrot_fullscreen='1';;
-			-D|--screenshot-delay) cfg_scrot_delay="$2"; shift;;
-			
-			-h|--help|--usage) sup.usage; return;;
-
-			--) shift; break;;
-
-			*) break;;
-		esac
-		shift
-	done
-
-	sup.env
-
-	if (( flag_scrot )); then
-		file=$(sup.scrot) || { return 1; }
-	else
-		(( $# )) || {
-			sup.usage
-			return 1
-		}
-
-		target="$1"
-
-		if sup.if_url "$target"; then
-			file=$(sup.mktemp "$cfg_tmp_dir")
-
-			curl -skL "$target" > "$file" || {
-				sup.err "Could not download file."
-				return 1
-			}
-		else
-			file="$target"
-
-			[[ -f "$file" ]] || {
-				sup.err "No such file: ${file}"
-				return 1
-			}
-		fi
-	fi
-
-	sup.upload
-}
-
-sup.set_argv "$@"
-main "${argv[@]}"

ufw

@@ -0,0 +1,413 @@
+#!/usr/bin/bash
+# Copyright (c) 2012 fbt <fbt@fleshless.org>
+# License: ISC
+#
+# About:
+# A simple upload script for UFW (http://zerofiles.org)
+
+_cat() {
+	while read; do
+		printf '%s\n' "$REPLY"
+	done
+}
+
+is_url() {
+	[[ "$1" =~ $cfg_url_regex ]]
+}
+
+msg() {
+	if ! (( flag_quiet )); then
+		printf '%s\n' "$1"
+	fi
+}
+
+err() { printf '(error) %s\n' "$*" >&2;  }
+
+usage() {
+	_cat <<- EOF
+		Usage: ufw [-RsF] [-D num] [file/url]"
+		    Flags:
+		        -R|--remove-file              # Remove the file after uploading.
+		        -s|--screenshot               # Make a screenshot and upload it instead of a file.
+		        -F|--fullscreen               # Make a fullscreen shot instead of prompting for a window/area. Implies -s.
+		        -d|--description              # Supply a description.
+		        -D|--screenshot-delay <num>   # Delay the shot by <num> seconds.
+		        -p|--public                   # Make the file public.
+		        -u|--shorten <URL>            # Generate a shortlink from URL.
+		        -S|--short-url                # Get a shortlink when uploading a file.
+		        -P|--page-url                 # Get a link to the file page instead of a direct one.
+		        -m|--max-filesize <num>[suf]  # Maximum filesize (takes K, M and G suffixes).
+		        -a|--album-id                 # Add the file to an album.
+		        -A|--album-name               # Add the file to an album by name. The album will be created, if necessary.
+		
+		    Config options (~/.config/ufw):
+		        secret               # Your personal token. Get it at https://zfh.so/settings_form
+		        cfg_screenshot_ext   # Screenshot file type, used by maim.
+		        cfg_max_filesize     # Maximum filesize (takes K, M and G suffixes).
+		        # Others are self-explanatory:
+		        cfg_url_regex
+		        cfg_tmp_dir
+		        cfg_service_url
+		        cfg_api_path
+	EOF
+}
+
+get_file_hash() {
+	read file_hash _ < <( sha1sum "$1" )
+}
+
+get_max_filesize() {
+	if [[ $cfg_max_filesize =~ ^[0-9]+[BKMG]?$ ]]; then
+		max_filesize_base="${cfg_max_filesize//[BKMG]/}"
+
+		case "$cfg_max_filesize" in
+			*K) max_filesize_bytes=$(( max_filesize_base * 1024 ));;
+			*M) max_filesize_bytes=$(( max_filesize_base * 1024 * 1024 ));;
+			*G) max_filesize_bytes=$(( max_filesize_base * 1024 * 1024 * 1024 ));;
+			*) max_filesize_bytes=$max_filesize_base;;
+		esac
+	else
+		err "Wrong cfg_max_filesize: $cfg_max_filesize"
+		return 1
+	fi
+}
+
+get_album_id() {
+	declare api_response api_status api_status_message
+
+	api_response=$( curl -fsL "$cfg_service_url/$cfg_api_path/album?a=new&name=$1&format=json&secret=$secret" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		album_id=$( jshon -e data -e album -e id -u <<< "$api_response" )
+		misc_curl_args+=( -F album_id="$album_id" )
+	else
+		printf 'Error [album]: %s %s\n' "$api_status" "$api_status_message"
+		return 1
+	fi
+}
+
+upload() {
+	declare api_response api_status api_status_message
+
+	if (( flag_scn )); then
+		flag_rm=1
+		file=$(take_screenshot) || { return 1; }
+	else
+		(( $# )) || {
+			usage
+			return 1
+		}
+
+		target="$1"
+
+		if is_url "$target"; then
+			flag_rm=1
+			file=$(_mktemp "$cfg_tmp_dir")
+
+			get_max_filesize || { return 1; }
+
+			curl --max-filesize "$max_filesize_bytes" -skL "$target" > "$file"
+			curl_result=$?
+
+			if (( curl_result )); then
+				case "$curl_result" in
+					63) err "File exceeds cfg_max_filesize";;
+					*) err "Could not download file.";;
+				esac
+
+				return 1
+			fi
+		else
+			file="$target"
+
+			[[ -f "$file" ]] || {
+				err "No such file: ${file}"
+				return 1
+			}
+		fi
+	fi
+
+	get_file_hash "$file"
+
+	if [[ "$album_name" ]]; then
+		get_album_id "$album_name"
+	fi
+
+	api_response=$( curl -sL \
+		-F file="@$file" \
+		-F api_format='json' \
+		-F flag_private="$flag_private" \
+		-F secret="$secret" \
+		-F submit="" \
+		"${misc_curl_args[@]}" \
+		-A 'zerofiles.org upload script' \
+		"$cfg_service_url/$cfg_api_path/upload" )
+
+	if (( flag_shortlink )); then
+		if (( flag_directlink )); then
+			file_url_request='short_url_direct'
+		else
+			file_url_request='short_url'
+		fi
+	else
+		if (( flag_directlink )); then
+			file_url_request='direct_url'
+		else
+			file_url_request='page_url'
+		fi
+	fi
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		file_link=$( jshon -e data -e file -e "$file_url_request" -u <<< "$api_response" )
+
+		printf '%s\n' "$file_link"
+
+		if (( flag_rm )); then
+			msg "Removing file: $file"
+			rm "$file"
+		fi
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+		return 1
+	fi
+}
+
+get_shortlink() {
+	declare url=$1 api_response api_status api_status_message
+
+	api_response=$( curl -sL "$cfg_service_url/$cfg_api_path/url?a=add&url=${url}&format=json&secret=$secret" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		read -r short_url real_url < <(
+			jshon -e data -e URL -e shorturl -u <<< "$api_response"
+		)
+
+		printf '%s\n' "$short_url"
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+	fi
+}
+
+take_screenshot() {
+	declare tmp_file
+
+	[[ "$scn_exec" ]] || { scn_exec=$(type -P maim); }
+	[[ "$scn_exec" ]] || {
+		err "Please install maim to use this function"
+		return 1
+	}
+
+	(( "$flag_scn_fullscreen" )) || { scn_args+=( '-s' ); }
+	[[ "$cfg_scn_delay" ]] && { scn_args+=( "-d $cfg_scn_delay" ); }
+
+	tmp_file="$(_mktemp "${cfg_tmp_dir}" ".${cfg_screenshot_ext}")"
+
+	maim "${scn_args[@]}" "$tmp_file" || {
+		err "Failed to take a screenshot."
+		return 1
+	}
+
+	printf '%s\n' "$tmp_file"
+}
+
+get_api_status() {
+	read -d '' -r api_status api_status_message < <(
+		jshon -e status -e code -u -p -e message -u
+	)
+
+	if ! (( api_status == 200 )); then
+		return 1
+	fi
+}
+
+_mktemp() {
+	declare tmp_file_name tmp_file_name_extra="$2" tmp_dir="$1" 
+
+	[[ -d "$tmp_dir" ]] || {
+		err "${tmp_dir} does not exist or is not a directory."
+		return 1
+	}
+
+	until [[ ! -e "${tmp_dir}/${tmp_file_name}" ]]; do
+		tmp_file_name="${RANDOM}${RANDOM}${tmp_file_name_extra}"
+	done
+
+	printf '%s\n' "${tmp_dir}/${tmp_file_name}"
+}
+
+get_my_ip() {
+	declare api_response api_status api_status_message my_ip
+
+	api_response=$( curl -sl "$cfg_service_url/$cfg_api_path/ip?format=json" )
+
+	get_api_status <<< "$api_response"
+
+	if (( api_status == 200 )); then
+		my_ip=$( jshon -e data -e ip -u <<< "$api_response" )
+		printf '%s\n' "$my_ip"
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+	fi
+}
+
+login() {
+	declare api_response
+
+	api_response=$( curl -sl "$cfg_service_url/$cfg_api_path/get_login_token?login=$login&format=json" )
+
+	if get_api_status <<< "$api_response"; then
+		printf 'Check your email.\n'
+	else
+		printf 'Error: %s %s\n' "$api_status" "$api_status_message"
+	fi
+}
+
+set_argv() {
+	declare arg opt c
+	declare -g argv
+
+	while (( $# )); do
+		unset -v arg opt c
+
+		case "$1" in
+			(--) argv+=( "$1" ); break;;
+
+			(--*)
+				IFS='=' read arg opt <<< "$1"
+				argv+=( "$arg" )
+
+				[[ "$opt" ]] && {
+					argv+=( "$opt" )
+				}
+			;;
+
+			(-*)
+				while read -n1 c
+				do
+					case "$c" in
+						-|'') :;;
+						*) argv+=( "-$c" );;
+					esac
+				done <<< "$1"
+			;;
+
+			(*) argv+=( "$1" );;
+		esac
+		shift
+	done
+}
+
+main() {
+	declare args file target flag_private flag_rm flag_scn flag_scn_fullscreen cfg_scn_delay
+	declare flag_shortlink=0
+
+	# Defaults for XDG
+	if ! [[ "$XDG_RUNTIME_DIR" ]]; then
+		XDG_RUNTIME_DIR="/run/user/$UID"
+	fi
+
+	if ! [[ "$XDG_CONFIG_DIR" ]]; then
+		XDG_CONFIG_DIR="$HOME/.config"
+	fi
+
+	cfg_url_regex='^[A-Za-z]([A-Za-z0-9+.-]+)?://.+'
+	cfg_tmp_dir="$XDG_RUNTIME_DIR/ufw"; TEMPDIR="$cfg_tmp_dir"
+	cfg_service_url='https://8fw.me'
+	cfg_screenshot_ext='png'
+	cfg_max_filesize='200M'
+	cfg_api_path='/api/2'
+
+	flag_shortlink=0
+	flag_directlink=1
+
+	if [[ -f "$HOME/.suprc" ]]; then
+		printf 'Found legacy configfile, moving...\n' >&2
+		mv "$HOME/.suprc" "$XDG_CONFIG_DIR/ufw"
+	fi
+
+	if [[ -f "$XDG_CONFIG_DIR/ufw" ]]; then
+		if ! source "$XDG_CONFIG_DIR/ufw"; then
+			printf 'Failed to source configuration file: %s\n' "$XDG_CONFIG_DIR/ufw"
+			return $?
+		fi
+	fi
+
+	while [[ "$1" ]]; do
+		case "$1" in
+			-h|--help|--usage) usage; return;;
+			-D|--screenshot-delay) cfg_scn_delay="$2"; shift;;
+			-m|--max-filesize) cfg_max_filesize=$2; shift;;
+			-A|--album-name) album_name=$2; shift;;
+
+			-i|--my-ip) action='getmyip';;
+			-u|--shorten) action='url';;
+
+			-p|--public) flag_private='false';;
+			-R|--remove-file) flag_rm='1';;
+			-s|--screenshot) flag_scn='1';;
+			-S|--short-url) flag_shortlink=1;;
+			-P|--page-url) flag_directlink=0;;
+			-q|--quiet) flag_quiet=1;;
+
+			-F|--fullscreen)
+				flag_scn='1'
+				flag_scn_fullscreen='1'
+			;;
+
+			-a|--album-id)
+				misc_curl_args+=( -F "album_id=$2" )
+				shift
+			;;
+
+			-d|--description)
+				misc_curl_args+=( -F "description=$2" )
+				shift
+			;;
+
+			--) shift; break;;
+
+			-*)
+				err "Unknown flag: $1"
+				usage
+				return 1
+			;;
+
+			*) break;;
+		esac
+		shift
+	done
+
+	for i in "$cfg_tmp_dir"; do
+		[[ -d "$i" ]] || { mkdir -p "$i"; }
+	done
+
+	case "${action:-upload}" in
+		upload)
+			if (( $# )); then
+				for t in "$@"; do
+					upload "$t"
+				done
+			else
+				upload
+			fi
+		;;
+
+		url)
+			for t in "$@"; do
+				get_shortlink "$1"
+			done
+		;;
+
+		getmyip) get_my_ip;;
+		login) login;;
+	esac
+}
+
+set_argv "$@"
+main "${argv[@]}"

ufwd

@@ -0,0 +1,80 @@
+#!/usr/bin/env bash
+shopt -s nullglob
+
+# Defaults for XDG
+if ! [[ "$XDG_RUNTIME_DIR" ]]; then
+	XDG_RUNTIME_DIR="/run/user/$UID"
+fi
+
+msg() { printf '%s\n' "$*"; }
+err() { echo "$*" >&2; }
+
+usage() {
+	printf 'Usage: ufwd [-hn] [-d workdir] -D [check delay]\n'
+	printf '   -h            # Show this message.\n'
+	printf '   -n            # Enable notifications with notify-send. Must be installed.\n'
+	printf '   -d [path]     # Set the dir that is to be watched.\n'
+}
+
+upload() {
+	declare file=$1; shift
+
+	upload_output=$( ufw -R "$@" "$file" )
+	upload_return=$?
+
+	if (( flag_enable_notifications )); then
+		if (( $upload_return )); then
+			notify-send 'ufwd' "File upload failed: $upload_output"
+		else
+			notify-send 'ufwd' "File uploaded: $upload_output"
+		fi
+	fi
+
+	if (( flag_enable_clipboard )); then
+		read -r fl <<< "$upload_output"
+		xclip <<< "$fl"
+	fi
+
+	printf '%s\n' "$upload_output"
+}
+
+main() {
+	while (( $# )); do
+		case "$1" in
+			(--help|-h) usage; return 0;;
+			(--notify|-n) flag_enable_notifications=1;;
+			(--clipboard|-c) flag_enable_clipboard=1;;
+
+			(--workdir|-d) cfg_workdir+=( "$2" ); shift;;
+
+			(--) shift; break;;
+			(-*) err "Unknown key: $1"; usage; return 1;;
+			(*) break;;
+		esac
+		shift
+	done
+
+	[[ $cfg_workdir ]] || cfg_workdir="$XDG_RUNTIME_DIR/ufwd"
+
+	if (( flag_enable_notifications )); then
+		if type -P notify-send &>/dev/null; then
+			msg "Found notify-send."
+		else
+			err "notify-send not found in PATH, disabling notifications."
+			flag_enable_notifications=0
+		fi
+	fi
+
+	for p in "${cfg_workdir[@]}"; do
+		[[ -d "$p" ]] || return 1
+	done
+
+	printf 'Working in:\n'
+	printf ' - %s\n' "${cfg_workdir[@]}"
+
+	while read -r d e f; do
+		upload "$d$f" "$@" &
+	done < <( inotifywait -m -e close_write "${cfg_workdir[@]}" )
+}
+
+main "$@"